Re: unicodeio.c ignores fwrite return value

[Jim Meyering]

Jim Meyering <address@hidden> wrote:
...
>> 2008-11-12  Bruno Haible  <address@hidden>
>>
>>      * lib/unicodeio.c: Include unistr.h.
>>      (utf8_wctomb): Remove function.
>>      (unicode_to_mb): Use utf8_uctomb instead of utf8_wctomb.
>
> This causes a link error in coreutils, due to the absence of a utf8_uctomb
> definition.  Is it defined in some file you have yet to commit?
> Or is that supposed to be some other symbol?

Oh, I see it.
Here's the patch:

>From 1d3a9b3d4dc5fdaf193ed3b810018f12df672842 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 12 Nov 2008 15:27:38 +0100
Subject: [PATCH] * lib/unicodeio.c (unicode_to_mb): Correct spelling of 
u8_uctomb.

---
 ChangeLog       |    4 ++++
 lib/unicodeio.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9bb918e..869ffcd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-11-12  Jim Meyering  <address@hidden>
+
+       * lib/unicodeio.c (unicode_to_mb): Correct spelling of u8_uctomb.
+
 2008-11-12  Simon Josefsson  <address@hidden>

        * modules/warnings (configure.ac): Do AC_SUBST([WARN_CFLAGS]) here
diff --git a/lib/unicodeio.c b/lib/unicodeio.c
index bfe7483..9d50a40 100644
--- a/lib/unicodeio.c
+++ b/lib/unicodeio.c
@@ -106,7 +106,7 @@ unicode_to_mb (unsigned int code,
     }

   /* Convert the character to UTF-8.  */
-  count = utf8_uctomb ((unsigned char *) inbuf, code, sizeof (inbuf));
+  count = u8_uctomb ((unsigned char *) inbuf, code, sizeof (inbuf));
   if (count < 0)
     return failure (code, N_("character out of range"), callback_arg);

--
1.6.0.4.857.gaca5