Re: select self-tests causes build failures under mingw

[Simon Josefsson]

Paolo Bonzini <address@hidden> writes:

> Simon Josefsson wrote:
>> GnuTLS fails to build under mingw (see output below), and the reason is
>> that the select-tests module depends on gettimeofday module, which under
>> mingw does this:
>> 
>>   AC_DEFINE([localtime], [rpl_localtime],
>>     [Define to rpl_localtime if the replacement function should be used.])
>> 
>> This re-definition causes the link failure, because gettimeofday.c is
>> not build as part of the replacement gnulib library, so there is no
>> rpl_localtime symbol.  It is only built in the gnulib self-test
>> directory (gl/tests/ in gnutls).
>> 
>> Does anyone see a clean solution to this problem?
>
> First of all, would this be fixed by moving the define into lib/time.in.h?

If the generated time.h file is placed in gl/tests/, then I think it
would work.  But if it ends up in gl/ the src/*.c files will #include
it, and there will be the same problem again.  I'm not sure gnulib-tool
supports time.h in both gl/ and gl/tests with different definitions?

Maybe gnulib self-tests directories should have their own configure.ac
and config.h, although I fear the build-times of having 6 CONFIG_SUBDIR
statements in GnuTLS...  I'd probably prefer to disable the gnulib
self-tests.  Even the move to 3 CONFIG_SUBDIR's causes significant
slow-down.

/Simon