bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?


From: Jim Meyering
Subject: Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?
Date: Sat, 29 Nov 2008 16:14:05 +0100

"James Youngman" <address@hidden> wrote:
> As far as I can see, the variable type is assigned in the function
> above, but never used.   Did you mean to use "type" rather than
> "dtype" in the expression which assigns to st->st_mode?

Thanks again.
Here's the patch I'll push as soon as you say ok:

>From 9c0c94835f6660cd62fc1797368d9aab86ff41a4 Mon Sep 17 00:00:00 2001
From: James Youngman <address@hidden>
Date: Sat, 29 Nov 2008 16:08:09 +0100
Subject: [PATCH] * lib/fts.c (set_stat_type): Fix a bug: was using wrong 
variable.

---
 ChangeLog |    4 ++++
 lib/fts.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9a4ae1f..b6ce284 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-11-29  James Youngman  <address@hidden>
+
+       * lib/fts.c (set_stat_type): Fix a bug: was using wrong variable.
+
 2008-11-29  Jim Meyering  <address@hidden>

        fts: provide dirent.d_type via FTSENT.fts_statp, when possible
diff --git a/lib/fts.c b/lib/fts.c
index 35def60..dcf10e1 100644
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1063,7 +1063,7 @@ set_stat_type (struct stat *st, unsigned int dtype)
     default:
       type = 0;
     }
-  st->st_mode = dtype << s_ifmt_shift_bits ();
+  st->st_mode = type << s_ifmt_shift_bits ();
 }

 /*
--
1.6.0.4.1101.g642f8




reply via email to

[Prev in Thread] Current Thread [Next in Thread]