[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?
From: |
Jim Meyering |
Subject: |
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ? |
Date: |
Sat, 29 Nov 2008 17:00:48 +0100 |
Jim Meyering <address@hidden> wrote:
> Jim Meyering <address@hidden> wrote:
>> "James Youngman" <address@hidden> wrote:
>>> As far as I can see, the variable type is assigned in the function
>>> above, but never used. Did you mean to use "type" rather than
>>> "dtype" in the expression which assigns to st->st_mode?
>>
>> Thanks again.
>> Here's the patch I'll push as soon as you say ok:
>
> I hadn't tested enough after all.
> That didn't work either. But this does.
> With *it*, all 1133 of find's tests really do pass:
>
>>From fb3d1318c0ea7f675b0702897c35f83198efdae8 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Sat, 29 Nov 2008 16:08:09 +0100
> Subject: [PATCH] fts: fix a thinko
>
> * lib/fts.c (s_ifmt_shift_bits): Remove function. Not needed after all.
> (set_stat_type): Return S_IF*-valued "type" directly.
> Prompted by James Youngman's spotting a related bug.
> Confirmed by further testing through find.
I've just pushed that one.
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Eric Blake, 2008/11/27
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/28
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/28
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/30
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?,
Jim Meyering <=
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Christian Franke, 2008/11/28