bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] posixtm.c: avoid a warning


From: Jim Meyering
Subject: [PATCH] posixtm.c: avoid a warning
Date: Mon, 08 Dec 2008 14:02:54 +0100

FYI, I remove the following if-lint code, since it is no longer
needed (with gcc4), and in fact would provoke its own warning.

>From 37bc76801091560c6f1be54925d2942c0f66912a Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 7 Dec 2008 18:47:02 +0100
Subject: [PATCH] posixtm.c: avoid a warning

* lib/posixtm.c (posixtime): Don't initialize tm0.
It's no longer needed to placate gcc4's -Wuninitialized,
and the attempt to placate would elicit a new warning.
---
 ChangeLog     |    5 +++++
 lib/posixtm.c |   10 +---------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2865b54..5f11392 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-12-07  Jim Meyering  <address@hidden>

+       posixtm.c: avoid a warning
+       * lib/posixtm.c (posixtime): Don't initialize tm0.
+       It's no longer needed to placate gcc4's -Wuninitialized,
+       and the attempt to placate would elicit a new warning.
+
        unicodeio.c: mark unused parameters
        * lib/unicodeio.c (exit_failure_callback): Mark unused parameter.
        (fallback_failure_callback): Likewise.
diff --git a/lib/posixtm.c b/lib/posixtm.c
index fff53f5..7740f4d 100644
--- a/lib/posixtm.c
+++ b/lib/posixtm.c
@@ -186,15 +186,7 @@ posix_time_parse (struct tm *tm, const char *s, unsigned 
int syntax_bits)
 bool
 posixtime (time_t *p, const char *s, unsigned int syntax_bits)
 {
-  struct tm tm0
-#ifdef lint
-  /* Placate gcc-4's -Wuninitialized.
-     posix_time_parse fails to set all of tm0 only when it returns
-     nonzero (due to year() returning nonzero), and in that case,
-     this code doesn't use the tm0 at all.  */
-    = { 0, }
-#endif
-    ;
+  struct tm tm0;
   struct tm tm1;
   struct tm const *tm;
   time_t t;
--
1.6.1.rc1.333.gba3cb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]