bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.


From: Eric Blake
Subject: Re: [PATCH] warnings: Add gl_WARN_COMPLEMENT and gl_WARN_SUPPORTED.
Date: Tue, 09 Dec 2008 06:12:24 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 12/8/2008 4:07 PM:
> Before doing that, I'd like to see the results that Simon, Jim, Eric, and
> others get on reasonably large code bases. My list of warnings to avoid
> is certainly biased. What we document in the manual should not be biased.

The master branch of m4.git tries these flags:

    CFLAGS="$CFLAGS -Wall"
    WMORE="-Wshadow -Wpointer-arith -Wcast-align -Wnested-externs"
    WMORE="$WMORE -Wmissing-prototypes -Wmissing-declarations -Winline"

but some of them fail while compiling libtool, so I haven't really tested
many of these optional warning flags.  -Wshadow is a policy flag (it can
catch bugs, but more often catches unwanted warnings about system headers
interfering with the choice of local variable name), -Wpointer-arith is
real (not all compilers handle math on void*), -Wmissing-prototypes and
- -Wmissing-declarations appear to be policy flags (I can't think of any
bugs ever caught in my use of them), and I'm not too sure of the value of
the others.  I'm probably going to change m4's ltdl/m4/debug.m4 file to
use the new manywarnings module.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk+brgACgkQ84KuGfSFAYDNTACeP3w59WxoSSCd1jUCzkPLGeNO
eIoAoLYwzb91gSR3zCuyhUGTL76jf8bt
=a9J2
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]