[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] setsockopt: Add support for timeouts on W32
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] setsockopt: Add support for timeouts on W32 |
Date: |
Mon, 29 Dec 2008 11:18:02 +0100 |
User-agent: |
Thunderbird 2.0.0.18 (Macintosh/20081105) |
> Looks all fine to me, but it's Simon and Paolo who have to decide on this.
> Good point. The prototypes should have socklen_t.
Both are ok.
> Here is another proposed
> patch, also for consideration by Simon and Paolo. - Regarding 'restrict',
> I never use this keyword because AFAIK, omitting it has no effect on
> correct programs; its presence is only a hint to the user that uses of
> the functions with daring overlap of argument locations are invalid,
> and in most cases a considerate programmer will not pass overlapping
> arguments to functions anyway. - Please correct me if I'm wrong.
If you want to add restrict since you are at it, why not.
Paolo