bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] do not have regex depend on obsolete modules


From: Bruno Haible
Subject: Re: [PATCH] do not have regex depend on obsolete modules
Date: Tue, 20 Jan 2009 21:22:34 +0100
User-agent: KMail/1.9.9

Paolo Bonzini wrote:
> 2009-01-20  Paolo Bonzini  <address@hidden>
> 
>         regex: do not depend on obsolete modules.
>         * modules/regex: Remove memcmp and memmove.
> 
> diff --git a/modules/regex b/modules/regex
> index c6a1235..86a19fb 100644
> --- a/modules/regex
> +++ b/modules/regex
> @@ -18,8 +18,6 @@ extensions
>  gettext-h
>  localcharset
>  malloc
> -memcmp
> -memmove
>  mbrtowc
>  mbsinit
>  stdbool

This is not needed. gnulib-tool by default ignores dependencies to obsolete
modules already.

$ ./gnulib-tool --help
...
      --with-obsolete       Include obsolete modules when they occur among the
                            dependencies. By default, dependencies to obsolete
                            modules are ignored.
...

Your patch causes missing dependencies when people voluntarily use the
--with-obsolete option.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]