[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] setsockopt: Add support for timeouts on W32
From: |
Martin Lambers |
Subject: |
Re: [PATCH] setsockopt: Add support for timeouts on W32 |
Date: |
Mon, 2 Feb 2009 18:36:56 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, 26. Dec 2008, 01:35:46 +0100, Bruno Haible wrote:
> > Here's an updated
> > patch. I used memcpy() because POSIX requires silent truncation of the
> > option value in case optlen is smaller than necessary.
>
> Looks all fine to me, but it's Simon and Paolo who have to decide on this.
>
> > Is there a reason that the replacement getsockopt and setsockopt
> > functions do not use the POSIX prototype (pointers with the 'restrict'
> > keyword, length arguments with socklen_t)?
>
> Good point. The prototypes should have socklen_t. Here is another proposed
> patch, also for consideration by Simon and Paolo.
Simon, Paolo, do you have any comments on the patches suggested in this
thread?
Martin
- Re: [PATCH] setsockopt: Add support for timeouts on W32,
Martin Lambers <=