Re: [Mark McLoughlin] [PATCH] gnulib/tests: allow test-getaddrinfo to pass when offline

[Ondřej Vašík]

Jim Meyering wrote:
> +      if (res == EAI_AGAIN)
> +     {
> +       fprintf (stderr, "skipping getaddrinfo test: no network?\n");
> +       return 77;
> +     }

Actually this does break the test-suite if more than one of the subtests
are skipped (network unavailable - e.g. coreutils koji build). I guess
the easiest way would be to have static variable skip and after skip,
return 0 for any other tests (without doing anything). It should not
break anything - as if the result before skip was 0, it will be 77
(skip), if the result was 1(fail), it will be 78(which is still fail).
Now if all of the getaddr tries (now 4) are skipped, result is 4x77 -
which is not skip.


Attached patch fixes that behaviour.

Greetings,
         Ondrej Vasik

getaddrinfoskipexitcode.patch
Description: Text Data

signature.asc
Description: Toto je digitálně podepsaná část zprávy