bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #6758] Add support for Atari FreeMiNT OS


From: Alan Hourihane
Subject: Re: [patch #6758] Add support for Atari FreeMiNT OS
Date: Sat, 28 Feb 2009 23:31:46 +0000

On Sat, 2009-02-28 at 22:33 +0000, Alan Hourihane wrote:
> On Sat, 2009-02-28 at 22:46 +0100, Bruno Haible wrote:
> > Hi Alan,
> > 
> > > I see this has already landed in git, so let me know how you want to
> > > handle any updates.
> > 
> > Can you please take the current gnulib (git HEAD), execute the tests in
> > the way I mentioned, show us the test failures (with line numbers of the
> > failing ASSERT) and then put in the minimal set of modifications that gets
> > the failures fixed?
> 
> These are the failures with git HEAD.
> 
> make[4]: Entering directory `/j/tmp/testdir-mint/gltests'
> PASS: test-binary-io.sh
> PASS: test-fbufmode
> ftell result is wrong after fseek: 0.
> FAIL: test-fflush
> test-fflush2.c:71: assertion failed
> ./test-fflush2.sh: line 5:   642 Abort                   ./test-fflush2
> ${EXEEXT} 1 < "$srcdir/test-fflush2.sh"
> FAIL: test-fflush2.sh
> PASS: test-fpending.sh
> test-fpurge.c:78: assertion failed
> /bin/sh: line 4:   652 Abort                   EXEEXT='' EXEEXT=''
> srcdir='.' EXEEXT='' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' ${dir}$tst
> FAIL: test-fpurge
> Skipping test: file operations failed.
> SKIP: test-freadable
> PASS: test-freadahead.sh
> Skipping test: file operations failed.
> SKIP: test-freading
> PASS: test-freadptr.sh
> PASS: test-freadptr2.sh
> test-freadseek.c:96: assertion failed
> ./test-freadseek.sh: line 3:   680
> Abort                   ./test-freadseek${EXEEXT} 5 19 6 7 18 9 19 <
> "$srcdir/test-freadseek.sh"
> FAIL: test-freadseek.sh
> test-fseeko.c:75: assertion failed
> ./test-fseeko.sh: line 3:   686 Abort                   ./test-fseeko
> ${EXEEXT} 1 < "$srcdir/test-fseeko.sh"
> FAIL: test-fseeko.sh
> test-fseeko.c:75: assertion failed
> /bin/sh: line 4:   691 Abort                   EXEEXT='' EXEEXT=''
> srcdir='.' EXEEXT='' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' ${dir}$tst
> FAIL: test-fseeko2.sh
> test-ftello.c:117: assertion failed
> ./test-ftello.sh: line 3:   697 Abort                   ./test-ftello
> ${EXEEXT} 1 < "$srcdir/test-ftello.sh"
> FAIL: test-ftello.sh
> test-ftello.c:117: assertion failed
> /bin/sh: line 4:   702 Abort                   EXEEXT='' EXEEXT=''
> srcdir='.' EXEEXT='' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
> srcdir='.' ${dir}$tst
> FAIL: test-ftello2.sh
> test-lseek.c:50: assertion failed
> ./test-lseek.sh: line 8:   708 Abort                   ./test-lseek
> ${EXEEXT} 0 < "$srcdir/test-lseek.sh" > t-lseek.tmp
> FAIL: test-lseek.sh
> PASS: test-stdbool
> PASS: test-stdio
> PASS: test-unistd
> ======================
> 9 of 18 tests failed
> (2 tests were not run)
> ======================
> 
> I'll change things around now.

The above is a little unfair as FreeMiNT has problems seeking beyond the
end of stdin, so I had to modify the test to remove that final check.

Attached are those patches to the tests.

Here's an updated report with the current git HEAD.

make[4]: Entering directory `/j/tmp/testdir-mint/gltests'
PASS: test-binary-io.sh
PASS: test-fbufmode
ftell result is wrong after fseek: 0.
FAIL: test-fflush
test-fflush2.c:71: assertion failed
./test-fflush2.sh: line 5:     6 Abort                   ./test-fflush2
${EXEEXT} 1 < "$srcdir/test-fflush2.sh"
FAIL: test-fflush2.sh
PASS: test-fpending.sh
test-fpurge.c:78: assertion failed
/bin/sh: line 4:    16 Abort                   EXEEXT='' EXEEXT=''
srcdir='.' EXEEXT='' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
srcdir='.' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
srcdir='.' ${dir}$tst
FAIL: test-fpurge
Skipping test: file operations failed.
SKIP: test-freadable
PASS: test-freadahead.sh
Skipping test: file operations failed.
SKIP: test-freading
PASS: test-freadptr.sh
PASS: test-freadptr2.sh
PASS: test-freadseek.sh
test-fseeko.c:75: assertion failed
./test-fseeko.sh: line 3:    50 Abort                   ./test-fseeko
${EXEEXT} 1 < "$srcdir/test-fseeko.sh"
FAIL: test-fseeko.sh
test-fseeko.c:75: assertion failed
/bin/sh: line 4:    55 Abort                   EXEEXT='' EXEEXT=''
srcdir='.' EXEEXT='' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
srcdir='.' EXEEXT='' srcdir='.' EXEEXT='' srcdir='.' EXEEXT=''
srcdir='.' ${dir}$tst
FAIL: test-fseeko2.sh
PASS: test-ftello.sh
PASS: test-ftello2.sh
PASS: test-lseek.sh
PASS: test-stdbool
PASS: test-stdio
PASS: test-unistd
======================
5 of 18 tests failed
(2 tests were not run)
======================

And now with all the additional patches I sent :-)

make[4]: Entering directory `/j/tmp/testdir-mint/gltests'
PASS: test-binary-io.sh
PASS: test-fbufmode
PASS: test-fflush
PASS: test-fflush2.sh
PASS: test-fpending.sh
PASS: test-fpurge
PASS: test-freadable
PASS: test-freadahead.sh
PASS: test-freading
PASS: test-freadptr.sh
PASS: test-freadptr2.sh
PASS: test-freadseek.sh
PASS: test-fseeko.sh
PASS: test-fseeko2.sh
PASS: test-ftello.sh
PASS: test-ftello2.sh
PASS: test-lseek.sh
PASS: test-stdbool
PASS: test-stdio
PASS: test-unistd
===================
All 20 tests passed
===================


Alan.

Attachment: tests.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]