[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] avoid gcc warnings about unused macro definitions
From: |
Bruno Haible |
Subject: |
Re: [PATCH] avoid gcc warnings about unused macro definitions |
Date: |
Fri, 13 Mar 2009 02:28:40 +0100 |
User-agent: |
KMail/1.9.9 |
Jim Meyering wrote:
> I'm not inclined to move
> definitions "down" into the #if blocks where they're used or even
> to add #if directives around the definition at the top.
I agree: The convention to put all miscellaneous macros used in a file near
the top, after the header file includes, is a good one. Adding more #ifs would
reduce maintainability and provoke coding mistakes.
Bruno