Re: Inaccurate description of configure option --without-included-regex

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Reuben Thomas on 3/17/2009 5:53 PM:
> On Tue, 17 Mar 2009, Jim Meyering wrote:
> 
>> Thanks.  That sounds like a fine improvement.
>> Do you feel like writing a commit-log/ChangeLog entry, too?
>> (i.e., git format-patch output, per e.g.,
>>  http://git.sv.gnu.org/cgit/coreutils.git/plain/HACKING)
> 
> Attached; since I haven't done this before, let me know what needs fixing.

There were some minor issues, but not enough to stop me from fixing them
myself (in part because I want to release m4 soon, and this fix should be
included).  For coreutils, Jim prefers that your first line look like:

regex: update and improve help for --without-included-regex

(ie. start with a category, use lower case, and no period).  But gnulib is
a bit looser on protocol (Jim and I tend to replicate our ChangeLog and
commit message, while Bruno uses just a full sentence one-line summary in
the commit message like you just did).

Next, any time you touch a *.m4 file, you should bump the serial number.
I did that for you in regex.m4.  Also, that particular file used TABs, but
you introduced 8 spaces (we're starting to lean towards always using
space, but on files where TAB is already in place, there's no point in
mixing styles).  On the other hand, ChangeLog should always use TABs,
because the GNU Coding Standards request it; I'm not sure about vi, but
emacs can automatically enforce that.

In the meantime, I did a search of the copyright assignments; I see that
you have assignment on file for coreutuils, but not gnulib.  Since it is a
separate project, I'd recommend repeating the process to ensure your
future gnulib contributions are not a problem.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknAQXAACgkQ84KuGfSFAYDr2ACgg4yqBefU5erfaRvfm46AesoE
HNMAnRBqcKuQYAZh11Qy9UrcQAfXvhz7
=RlMR
-----END PGP SIGNATURE-----