Re: ld-output-def

[Simon Josefsson]

Bruno Haible <address@hidden> writes:

> Hi Simon,
>
>> I kind of prefer the lib-* prefix because I think this is only ever
>> relevant for libraries.  That makes the name longer though.  Do we need
>> the -symbol- infix?
>
> Without the -symbol- infix, 'lib-versions' makes me think about the
> library versions (a.k.a. library soname) and libtool's versioning
> scheme; this is about the library as a whole.
>
> We have module names longer than that already:
>   posix_spawn_file_actions_addclose
>   relocatable-prog-wrapper
>   useless-if-before-free
>   lib-symbol-visibility
>
>> What about:
>> 
>> ld-version-script -> lib-versions
>> visibility        -> lib-visibility
>> ld-output-def     -> lib-msvc-compat
>
> I still prefer it with '-symbol-' infix for the first two.

Ok, I have pushed the patch below.

/Simon

>From 13e7b3562bf8212bec68e4945aca58185aa35ed5 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Wed, 1 Apr 2009 07:04:49 +0200
Subject: [PATCH] Rename ld-version-script to lib-symbol-versions.

---
 ChangeLog                   |    8 ++++++++
 MODULES.html.sh             |    1 +
 NEWS                        |    2 ++
 doc/ld-version-script.texi  |    6 +++---
 modules/ld-version-script   |   14 --------------
 modules/lib-symbol-versions |   14 ++++++++++++++
 6 files changed, 28 insertions(+), 17 deletions(-)
 delete mode 100644 modules/ld-version-script
 create mode 100644 modules/lib-symbol-versions

diff --git a/ChangeLog b/ChangeLog
index 3bf424d..bcf192b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-04-01  Simon Josefsson  <address@hidden>
+
+       Rename ld-version-script to lib-symbol-versions.  Suggested by
+       Bruno Haible <address@hidden>.
+       * modules/ld-version-script: Renamed to lib-symbol-versions.
+       * doc/ld-version-script.texi: Fix module name.
+       * MODULES.html.sh: Add lib-symbol-versions.
+
 2009-03-31  Simon Josefsson  <address@hidden>
 
        * modules/u64-tests: New file.
diff --git a/MODULES.html.sh b/MODULES.html.sh
index ecfda72..4175895 100755
--- a/MODULES.html.sh
+++ b/MODULES.html.sh
@@ -3132,6 +3132,7 @@ func_all_modules ()
   func_module include_next
   func_module ldd
   func_module lib-ignore
+  func_module lib-symbol-versions
   func_module link-warning
   func_module no-c++
   func_module relocatable-lib
diff --git a/NEWS b/NEWS
index b975d02..73e0c7e 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ User visible incompatible changes
 
 Date        Modules         Changes
 
+2009-04-01  ld-version-script  Renamed to lib-symbol-versions.
+
 2009-03-20  close           The substituted variable LIB_CLOSE is removed.
 
 2009-03-05  filevercmp      Move hidden files up in ordering.
diff --git a/doc/ld-version-script.texi b/doc/ld-version-script.texi
index fd57a08..e1feff5 100644
--- a/doc/ld-version-script.texi
+++ b/doc/ld-version-script.texi
@@ -1,9 +1,9 @@
 address@hidden LD Version Scripts
 @section LD Version Scripts
 
-The @code{ld-version-script} module can be used to add shared library
-versioning support.  Currently, only GNU LD and the Solaris linker
-supports this.
+The @code{lib-symbol-versions} module can be used to add shared
+library versioning support.  Currently, only GNU LD and the Solaris
+linker supports this.
 
 Version scripts provides information that can be used by GNU/Linux
 distribution packaging tools.  For example, Debian has a tool
diff --git a/modules/ld-version-script b/modules/ld-version-script
deleted file mode 100644
index 6b0d990..0000000
--- a/modules/ld-version-script
+++ /dev/null
@@ -1,14 +0,0 @@
-Description:
-Macros to test whether LD support --linker-script.
-
-Files:
-m4/ld-version-script.m4
-
-configure.ac:
-gl_LD_VERSION_SCRIPT
-
-License:
-unlimited
-
-Maintainer:
-Simon Josefsson
diff --git a/modules/lib-symbol-versions b/modules/lib-symbol-versions
new file mode 100644
index 0000000..6b0d990
--- /dev/null
+++ b/modules/lib-symbol-versions
@@ -0,0 +1,14 @@
+Description:
+Macros to test whether LD support --linker-script.
+
+Files:
+m4/ld-version-script.m4
+
+configure.ac:
+gl_LD_VERSION_SCRIPT
+
+License:
+unlimited
+
+Maintainer:
+Simon Josefsson
-- 
1.5.6.5