[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: string.h uses restrict

From: Reuben Thomas
Subject: Re: string.h uses restrict
Date: Mon, 6 Apr 2009 22:22:11 +0100 (BST)
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

On Mon, 6 Apr 2009, Jim Meyering wrote:

Ok by me. Though I don't like the use of $(C_SOURCES), as I mentioned. I do understand you're trying to do this gradually. I'd be inclined to make bigger changes ;-) It's only "make syntax-check", after all.

OK, I'm just trying to make changes that I can make reasonably confidently in little time and others review ditto!

Also, your change lacks a recent improvement:


The file-name-filtering grep commands (that test whether we have any
file to search) should all use -l, since all that matters is the
0/non-zero exit status; no sense in finding/printing all matches.

OK, in fact this only applies to one comment and one invocation of grep in my patch (the ChangeLog rule changes I can't use since they expect to have a complete list of files to look at and I only have C files at the moment).

Once this patch is in gnulib, I'll try to make another containing the rest of the syntax checks.

http://rrt.sc3d.org/ | Caution Children At Play Drive Slowly (Anon)

Attachment: maint.mk.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]