[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ls -v oddity with autosave files

From: Kamil Dudka
Subject: Re: ls -v oddity with autosave files
Date: Thu, 9 Apr 2009 13:40:38 +0200
User-agent: KMail/1.9.6 (enterprise 0.20071012.724442)

On Thursday 09 April 2009 11:32:58 Kamil Dudka wrote:
> On Thursday 09 April 2009 09:23:37 Sven Joachim wrote:
> > Note that the #.b# file is listed at the top in (1) and at the bottom in
> > (2), despite all filenames in the directory being the same!
> Thanks for discovering this! The transitive axiom of the predicate is
> broken. I am working on a fix. It seems like a regression from this commit:
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=0443c2f3994

The fix for hidden files was based on a really bad idea. I've replaced it
with a special handle for "", "." and "..".

Each strcmp compares max 2 or 3 chars, so there is no performance impact 
(tested with -02 with zero impact; with -O0 it takes about 2% more time on 
sorting 100000 items).

The behavior on the current test suite is unchanged and the suite has been 
enlarged with "" and "#.b#". Note that the suite has been already checking 
transitivity of the sort predicate, but the "#.b#" was not included.


Attachment: 0001-filevercmp-fix-regression.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]