Re: false positive in ld-version-script.m4

[Simon Josefsson]

Ralf Wildenhues <address@hidden> writes:

> Hi Simon,
>
> * Simon Josefsson wrote on Fri, Apr 03, 2009 at 02:24:04PM CEST:
>> --- a/m4/ld-version-script.m4
>> +++ b/m4/ld-version-script.m4
>> @@ -6,6 +6,11 @@ dnl with or without modifications, as long as this notice 
>> is preserved.
>>  
>>  dnl From Simon Josefsson
>>  
>> +# FIXME: The test below returns a false positive for mingw
>> +# cross-compiles, 'local:' statements does not reduce number of
>> +# exported symbols in a DLL.  Use --disable-ld-version-script to work
>> +# around the problem.
>> +
>>  # gl_LD_VERSION_SCRIPT
>
> Why not
>   AC_REQUIRE([AC_CANONICAL_HOST])
>   ...
>   case $host_os in mingw*) disable... ;; esac
>
> ?

That would work for now, but isn't such hard coding bad style in case
mingw ever fixes this problem?

Perhaps mingw cannot ever implement hiding of local symbols through
version scripts, and in that case we might hard code the check result.
But then, doesn't it seem better for gcc/ld to reject a version script
if it is impossible to support it?

/Simon