[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: maint.mk sync
From: |
Jim Meyering |
Subject: |
Re: maint.mk sync |
Date: |
Fri, 17 Apr 2009 10:23:08 +0200 |
Simon Josefsson wrote:
...
> But the checks aren't turned on by default, are they? The maintainer
> needs to invoke the specific rules manually.
Yes, they are run as part of "make syntax-check", by default.
>> Also, the diagnostic-checking rules are insufficiently general. At the
>> very least, they should take an optional cfg.mk-specified regexp to
>> identify the functions used to emit diagnostics.
>
> But it isn't used by default, either, is it?
It is.
>> One option is to maintain in maint.mk a list of the names of
>> less-generally-useful rules, and disable those by default.
>> Then we can leave most of the rules in the same file.
>
> I'd like something like that: I think multiple projects will want these
> less-generally-useful rules so it makes sense to share them.
>
> The only thing that is missing is to make it easy for maintainers to put
> something in cfg.mk that disables some checks they don't care about,
> alternatively list the checks they do care about.
That's already possible.
Just add names of unwanted checks to this variable in cfg.mk:
local-checks-to-skip = ...
> Hm. Possibly the 'syntax-check-rules' variable should only be set
> through '?=' Then every maintainer can filter out some checks they don't
> care about.
See above.