Re: maint.mk: makefile-check?

[Jim Meyering]

Simon Josefsson wrote:
> Is there any reason the makefile-check rule isn't called
> sc_makefile_check?

Solely that I hadn't done it yet.

> If it is because it may be used interactively by maintainers, we could
> add a rule like this:
>
> makefile-check: sc_makefile_check
>
> This seems cleaner than not using the sc_ convention for this check to me.

Definitely.  Thanks!

> /Simon
>
> diff --git a/top/maint.mk b/top/maint.mk
> index 3e27d7c..1c6e87b 100644
> --- a/top/maint.mk
> +++ b/top/maint.mk
> @@ -72,8 +72,7 @@ syntax-check-rules := $(shell sed -n 
> 's/^\(sc_[a-zA-Z0-9_-]*\):.*/\1/p' \
>  .PHONY: $(syntax-check-rules)
>
>  local-checks-available = \
> -  $(syntax-check-rules) \
> -  makefile-check
> +  $(syntax-check-rules)
>  .PHONY: $(local-checks-available)
>
>  # Arrange to print the name of each syntax-checking rule just before running 
> it.
> @@ -488,7 +487,7 @@ update-NEWS-hash: NEWS
>  # to emit a definition for each substituted variable.
>  # We use perl rather than "grep -nE ..." to exempt a single
>  # use of an @address@hidden variable name in src/Makefile.am.
> -makefile-check:
> +sc_makefile_check:
>       @perl -ne '/address@hidden@/ && !/^cu_install_program =/'       \
>         -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}'    \
>           $$($(VC_LIST_EXCEPT) | grep -E '(^|/)Makefile\.am$$')       \