[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk questions

From: Jim Meyering
Subject: Re: maint.mk questions
Date: Fri, 24 Apr 2009 23:22:59 +0200

Eric Blake wrote:

> Jim Meyering <jim <at> meyering.net> writes:
>> >
>> > In the case of m4, I've got a gnulib submodule, so I created a git symlink
> from
>> > my build-aux/config.guess into gnulib's copy.  Coreutils doesn't fail the
>> > sc_space_tab check because config.guess is not under version control
> (rather,
>> > it is copied into place during bootstrap), but because m4 maintains it as a
>> > symlink under version control, VC_LIST thinks it needs to be checked for
>> > syntax, even though it is an upstream file not subject to the same rules.
>> > Would it be worth changing vc-list-files to not follow git symlinks,
>> > particularly if those symlinks point into git submodules?
>> Yes, it sounds like that would be worthwhile -- at least to you.
> How about this patch?
> From: Eric Blake <address@hidden>
> Date: Fri, 24 Apr 2009 14:58:02 -0600
> Subject: [PATCH] vc-list-files: ignore git symlinks
> * build-aux/vc-list-files (.git): Use ls-tree and a filter, rather
> than ls-files, to ignore git symlinks.

Looks fine.
You're welcome to push it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]