Re: [PATCH] vc-list-files: restore lost functionality with subdir argument

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 4/25/2009 2:27 AM:
> The latest vc-list-files change made coreutils' "make sc_root_tests"
> fail, due to lack of the tests/ prefix on the listed file names.
> This fixes it, but adds the implicit constraint that the dirname
> argument to vc-list-files must not contain "!".

Good catch.

> +  eval exec git ls-tree -r 'HEAD:"$dir"' \
> +    \| sed -n '"s!^100[^     ]*.!'"$dir"'!p"' $postprocess

Is that the right quoting?  Remember, this line is going through an eval,
and we don't want a $dir containing whitespace to show up as separate
arguments to sed.  I think it should be:

eval exec git ls-tree -r 'HEAD:"$dir"' \
  \| sed -n '"s!^100[^  ]*.!$dir!p"' $postprocess

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkny/JQACgkQ84KuGfSFAYDAnACdHW/VHP5pjxXaax480mgYQ8jC
c80An1G3JYU12BbLnohY/c99lejlhkcn
=SnLS
-----END PGP SIGNATURE-----