[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vc-list-files: restore lost functionality with subdir argume
From: |
Eric Blake |
Subject: |
Re: [PATCH] vc-list-files: restore lost functionality with subdir argument |
Date: |
Sat, 25 Apr 2009 07:14:25 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 4/25/2009 6:05 AM:
>> + eval exec git ls-tree -r 'HEAD:"$dir"' \
>> + \| sed -n '"s!^100[^ ]*.!'"$dir"'!p"' $postprocess
>
> Is that the right quoting? Remember, this line is going through an eval,
> and we don't want a $dir containing whitespace to show up as separate
> arguments to sed. I think it should be:
>
> eval exec git ls-tree -r 'HEAD:"$dir"' \
> \| sed -n '"s!^100[^ ]*.!$dir!p"' $postprocess
I convinced myself. If $dir contains $, then you have the wrong quoting.
So I'm applying the above patch.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAknzDLEACgkQ84KuGfSFAYBUJACfcUo9MrIGSsKKXieaGkpzysk/
a7UAnRE3N01hrYhQHY2x0I/cl9MlzEKn
=qpqC
-----END PGP SIGNATURE-----