bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maintainer-makefile vs vc-list-files/useless-if-before-free


From: Simon Josefsson
Subject: Re: maintainer-makefile vs vc-list-files/useless-if-before-free
Date: Mon, 27 Apr 2009 14:33:46 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.92 (gnu/linux)

Eric Blake <address@hidden> writes:

> According to Simon Josefsson on 4/27/2009 6:19 AM:
>>> The intent is that your cfg.mk should point to the location where you
>>> expect to find a fresh gnulib checkout, so that you DON'T have to add
>>> a dependency on vc-list-files or useless-if-before-free.  Using
>>> maint.mk from gnulib implies that you have gnulib installed, which is
>>> why I was okay writing it in this way.
>> 
>> I don't think that is true -- I have been using maint.mk in several
>> projects without requiring a locally installed gnulib repository for
>> bootstrapping.
>> Given the above, this seems wrong to me.  Instead, why don't maint.mk
>> use the local build-aux/ path?  Right now it looks in the gnulib
>> directory (gnulib/) but the right thing seems like the maintainer should
>> --import vc-list-files and useless-if-before-free (possibly
>> maintainer-makefile should depend on them) and then maint.mk should call
>> the files from the locally imported build-aux/ directory.  Right?
>
> Yes, if we go this route, then we should make the maintainer-makefile
> module depend on both vc-list-files and useless-if-before-free.  I almost
> made this change as part of porting maint.mk to work with m4, but didn't
> do it because m4 falls in the first camp (bootstrap requires a gnulib
> checkout), but your arguments for the second camp (bootstrap is
> independent of gnulib) are good, so how about this patch instead?

That works for me.

> vc-list-files is a definite dependency, although I could be convinced to
> drop the dependency on useless-if-before-free for projects that choose to
> skip that particular syntax check, provided we also rewrite that check to
> first validate that build-aux/useless-if-before-free has been imported.

I don't think it is worth the effort.

/Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]