[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New sol10priv module
From: |
David Bartley |
Subject: |
Re: [PATCH] New sol10priv module |
Date: |
Fri, 1 May 2009 14:21:00 -0700 |
On Fri, May 1, 2009 at 4:35 AM, Bruno Haible <address@hidden> wrote:
> David Bartley wrote:
>> I've attached updated patches that hopefully
>> address your and Bruno's concerns.
>
> Looks quite fine. Only a couple of minor points:
>
> - m4/priv-set.m4 should do an AC_REQUIRE([AC_C_INLINE])
> because the .h file uses 'static inline'.
>
> - In priv-set.c, maybe add comments about
> - what eff_set contains,
> - what rem_set contains,
> - why we expect that priv_addset will not fail.
> These points are not immediately clear when reading the code.
>
> - An indentation problem in priv-set.c:39.
Updated the gnulib patch accordingly.
>
> Jim, I leave it to you to commit this for David, since I don't want to
> interfere with your coreutils release.
>
> Bruno
>
>
0001-New-module-priv-set-and-accompanying-tests.patch
Description: Text Data