bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: ensure that a release build fails when a submodule is


From: Eric Blake
Subject: Re: [PATCH] build: ensure that a release build fails when a submodule is unclean
Date: Sun, 03 May 2009 20:23:35 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 5/3/2009 7:40 AM:
>> Can we please make this VPATH safe?  $(srcdir)/.git
>>
>>> +     diff=$$(git submodule -q foreach git diff-index --name-only HEAD) \
>> diff=$$(cd $(srcdir) && git submodule...
> 
> Of course.
> Thanks!
> 
> How about this?
> 
> From: Eric Blake <address@hidden>
> Date: Sun, 3 May 2009 15:39:00 +0200
> Subject: [PATCH] maint: make the new no-submodule-changes rule VPATH-safe
> 
> * top/maint.mk (no-submodule-changes): Don't assume a srcdir build.

Thanks for writing the patch up for me.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkn+UacACgkQ84KuGfSFAYDWqQCdGpIUunphSYyFEA6SaIl9+wIO
+7MAoLLOI4CQc8FHQW7OhJXt3ABYAJ4W
=cWn9
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]