Re: sed --posix

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> According to Simon Josefsson on 5/27/2009 4:33 AM:
>> But adding --posix makes it fail:
>> 
>> address@hidden:~/src/libidn master$ echo 'version 2  '|sed --posix -e 
>> 's/version \(2\|2\.1\)\([ ,]\)/version 3\2/g'
>
> You are using \|, which is undefined in BRE, and therefore (correctly)
> rejected as a non-POSIX extension when using --posix with newer sed.  It
> was a bug in earlier sed that \| was not identified as non-portable.

Thanks.  I've pushed the patch below.

/Simon

>From 1b4d22d97c89b12231bfbb2527084d11e02a3d5f Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Wed, 27 May 2009 13:28:27 +0200
Subject: [PATCH] gnulib-tool: Don't use non-POSIX regexps.

---
 ChangeLog   |    6 ++++++
 gnulib-tool |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5b5348c..8b49c11 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-05-27  Simon Josefsson  <address@hidden>
+
+       * gnulib-tool (sed_transform_main_lib_file)
+       (sed_transform_testsrelated_lib_file): : Don't use non-POSIX
+       regexps.
+
 2009-05-26  Simon Josefsson  <address@hidden>
 
        * tests/test-strstr.c: Add another self-test.
diff --git a/gnulib-tool b/gnulib-tool
index f04be65..36ee714 100755
--- a/gnulib-tool
+++ b/gnulib-tool
@@ -2869,7 +2869,7 @@ s,^\(.................................................[^ 
]*\) *,
       sed_transform_main_lib_file=$sed_transform_main_lib_file'
         s/GNU Lesser General/GNU General/g
         s/GNU Library General/GNU General/g
-        s/version \(2\|2\.1\)\([ ,]\)/version 3\2/g
+        s/version 2\(.1\)\{0,1\}\([ ,]\)/version 3\2/g
       '
     fi
   fi
@@ -2881,7 +2881,7 @@ s,^\(.................................................[^ 
]*\) *,
     sed_transform_testsrelated_lib_file=$sed_transform_testsrelated_lib_file'
       s/GNU Lesser General/GNU General/g
       s/GNU Library General/GNU General/g
-      s/version \(2\|2\.1\)\([ ,]\)/version 3\2/g
+      s/version 2\(.1\)\{0,1\}\([ ,]\)/version 3\2/g
     '
   fi
 
-- 
1.6.2.4