Re: [PATCH] New fallocate module

[Pádraig Brady]

Eric Blake wrote:
> According to Pádraig Brady on 5/27/2009 10:20 AM:
>> Take 2 attached.
> 
>> Still outstanding from the gnulib portion is support for solaris.
>> I may get time to set this up, but I've very little time lately,
>> so I would like not to require this for merging.
> 
> That seems like a reasonable approach for a first cut, especially with
> your FIXME comment.
> 
>> +  dnl Persuade glibc <fcntl.h> to declare fallocate().
>> +  AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS])
> 
> Use gl_USE_SYSTEM_EXTENSIONS instead; it avoids some warnings from newer
> autoconf.

Done.
(I notice AC_USE_SYSTEM_EXTENSIONS seems to be used more):
  $ grep AC_USE_SYSTEM_EXTENSIONS *.m4 | wc -l
  54
  $ grep gl_USE_SYSTEM_EXTENSIONS *.m4 | wc -l
  34

I was also thinking a bit more about the current glibc interface.
I still don't like the requirement on <linux/falloc.h>, i.e.

  #if HAVE_LINUX_FALLOC_H
  # include <linux/falloc.h>
  #endif

I've added a query to the existing glibc fallocate bug,
as to whether <sys/falloc.h> should be available instead,
or even better, everything be available in fcntl.h

cheers,
Pádraig.