bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: another hash cleanup


From: Jim Meyering
Subject: Re: another hash cleanup
Date: Fri, 19 Jun 2009 16:02:41 +0200

Eric Blake wrote:
> According to Jim Meyering on 6/19/2009 7:06 AM:
>> Looks good, but I haven't tested.
>> Ok, presuming you have.
>
> Yes, I reran test-hash.c, as well as the m4 testsuite, using this version.
>
>>
>> One minor suggested change:
>>
>> Please combine the declaration and assignment:
>
> Done.  And with that on master, I've rebased my hash_rehash memory leak plug:

Thanks.

> http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash
> $ git pull git://repo.or.cz/gnulib/ericb.git hash

By the way, in this change set,

  http://repo.or.cz/w/gnulib/ericb.git?a=commitdiff;h=bf740889e7ca68be9e
  fake memory failure, for testing hash_rehash

I noticed that this is a no-op:

+            if (i == 363)
+               i = i * (i - 362);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]