[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gethostname inadvertently replaced on W32

From: Simon Josefsson
Subject: Re: gethostname inadvertently replaced on W32
Date: Tue, 28 Jul 2009 23:18:09 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.96 (gnu/linux)

Martin Lambers <address@hidden> writes:

> Hello again,
> I just noticed that this problem was already found and fixed by Simon in
> March: http://www.mail-archive.com/address@hidden/msg13671.html
> There was some discussion about the right approach, but no decision was
> made.
> Bruno, Simon, would you please reconsider applying the patch? Without
> it, the gethostname module is broken on W32.

Re-reading that thread, I think my patch is a reasonable way forward.
Avoiding linking to -lws2_32 is nice, but using GetComputerNameEx has
some issues (see my third e-mail in that thread) and ultimately it
doesn't seem worth it.

I propose we push my initial patch, and if Bruno feels strongly about
providing a gethostname function that works better under Windows,
without -lws2_32, that can be provided in a separate module (e.g.,
gethostname-lean).  Objections?

OTOH, I haven't tested whether my old patch still works.  Martin, have


reply via email to

[Prev in Thread] Current Thread [Next in Thread]