[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: more version-etc test fixes
From: |
Simon Josefsson |
Subject: |
Re: more version-etc test fixes |
Date: |
Fri, 14 Aug 2009 14:44:43 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Eric Blake <ebb9 <at> byu.net> writes:
>
>> > + -e 's/\r//g' |
>>
>> I'm not sure that sed s/\r//g is portable. You may have to resort to tr
>> instead.
>
> It's not (Solaris /bin/sed treats it like sed 's/\\r//g', looking for a
> 2-byte
> literal backslash and r sequence, rather than the intended 1-byte carriage
> return). Also, multiple sed -e is overkill when a single argument will do.
> And seeing the transformations in reverse order just looked weird. I'll be
> committing this (probably munged by gmane, since it also fixes some
> longer-than-
> 80-column lines):
Thank you!
/Simon