bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-izing sharutils


From: Bruno Haible
Subject: Re: gnulib-izing sharutils
Date: Sun, 30 Aug 2009 23:30:53 +0200
User-agent: KMail/1.9.9

Hi Bruce,

> gnulib-izing sharutils

You are welcome to send a one-line patch to gnulib/users.txt!

You are also welcome to help improving the gnulib documentation.

> I guess the following message is
> innocuous, but since I've got gettext version 0.17, couldn't this
> message get suppressed?  Or, is it intended that everyone should
> always put these things in the po/Makevars?  It isn't clear.
> If that is what was intended, this message won't reach the hapless
> builder of sharutils:
> 
> > Notice from module error:
> >   If you are using GNU gettext version 0.16.1 or older, add the following 
> > options
> >   to XGETTEXT_OPTIONS in your po/Makevars:
> >     --flag=error:3:c-format --flag=error_at_line:5:c-format

It cannot be easily suppressed, because gnulib-tool is run before the
gettext macros are collected by 'aclocal'.

Would it remove the confusion if I would add the following sentence to the
notice?

   "If you are using GNU gettext version 0.17 or newer, you can ignore this
    notice."

> More important issues:
> 
> * better instructions on where to place gl_INIT are needed.
>   I guessed at the top, but this:
> > configure.ac:10: warning: AC_COMPILE_IFELSE was called before 
> > AC_USE_SYSTEM_EXTENSIONS
> > m4/getopt.m4:50: gl_GETOPT_CHECK_HEADERS is expanded from...
> > m4/getopt.m4:43: gl_GETOPT_IFELSE is expanded from...
> > m4/getopt.m4:8: gl_FUNC_GETOPT_POSIX is expanded from...
> > m4/getopt.m4:21: gl_FUNC_GETOPT_GNU is expanded from...
> > m4/gnulib-comp.m4:33: gl_INIT is expanded from...
> > configure.ac:10: the top level
>   says otherwise in a quite confusing fashion.  If it ought to be
>   something like this:
> 
> > gl_INIT
> > AC_PROG_CC
> > gl_EARLY
> 
>   then maybe say so explicitly?

The order should be

   AC_PROG_CC
   gl_EARLY
   gl_INIT

The doc 
<http://www.gnu.org/software/gnulib/manual/html_node/Initial-import.html>
suggests
  "invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,"
and
  "... the macro gl_INIT. Place it further down in the file, typically where
   you normally check for header files or functions."

But there is a known problem with AC_USE_SYSTEM_EXTENSIONS in autoconf <= 2.63.
I'd suggest to use autoconf 2.64 and then remove all invocations of
AC_GNU_SOURCE.

> * I get a whole mess of messages like this.  Since none of this  appears in 
> either
>   configure.ac nor m4/sharutils.m4, I'm guessing some macro some where pulls 
> it in.
>   It is hard to trace though:
> > $ ls ../../../lib/autoconf
> > ls: cannot access ../../../lib/autoconf: No such file or directory
> 
>   So, to the messages:
> 
> configure.ac:21: warning: The macro `AC_TRY_RUN' is obsolete.

You can ignore these warnings. AC_TRY_RUN and AC_TRY_LINK cannot go away
because hundreds of autoconf macros use them.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]