bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] win32: Use ANSI functions


From: Jim Meyering
Subject: Re: [PATCH 1/5] win32: Use ANSI functions
Date: Thu, 01 Oct 2009 16:54:46 +0200

Paolo Bonzini wrote:
> Hi all, this is the first of a few patches to a few Win32 implementations
> of gnulib modules.
>
> This first one uses ANSI functions whenever we're passing or receiving
> strings, so that compiling with -DUNICODE succeeds.  I started from the
> list of Win32 API functions, which I got from
>
>   grep -orh '\<[A-Z][a-z][A-Za-z]*[A-Z][a-z][a-z]*\ (' *
>
> and then cleaned up the list to just a handful of them.  After this,
> I got carried away cleaning up uname, so this function is not in this
> patch.

Hi Paolo,

Just glancing through, some space-before-TAB sequences
jumped out at me because they were highlighted.
When changing so much, you might want to switch the affected
file to space-only indentation.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]