Re: test suite problems

[Bruno Haible]

Ian Beckwith wrote:
> Quite a few modules fail gnulib-tool --create-megatestdir --with-tests
> with the error:
> 
> > executing automake --add-missing --copy
> > Makefile.am: C objects in subdir but `AM_PROG_CC_C_O' not in `configure.ac'
> 
> Of these modules, the ones I checked had AM_PROG_CC_C_O in 
> <module>/configure.ac
> but not in <module>/gltests/configure.ac.

Indeed, I reproduce with the command
  ./gnulib-tool --create-testdir --with-tests --dir=/tmp/testdir1 mbscasestr
but only with automake version 1.9.6. The error is gone in automake >= 1.10;
this is probably an automake bug.

Fixed as follows:


2009-10-03  Bruno Haible  <address@hidden>

        * gnulib-tool (func_create_testdir): Conditionally emit AM_PROG_CC_C_O
        invocation to tests/configure.ac.
        Reported by Ian Beckwith <address@hidden>.

--- gnulib-tool.orig    2009-10-03 15:58:09.000000000 +0200
+++ gnulib-tool 2009-10-03 15:52:52.000000000 +0200
@@ -4019,6 +4019,10 @@
      echo "AC_PROG_MAKE_SET"
      echo "AC_PROG_RANLIB"
      echo
+     if test -n "$uses_subdirs"; then
+       echo "AM_PROG_CC_C_O"
+       echo
+     fi
      for module in $modules; do
        func_verify_module
        if test -n "$module"; then