size_max

[Simon Josefsson]

Jim Meyering <address@hidden> writes:

>> However given that SIZE_MAX should be in stdint.h according to POSIX,
>> maybe it makes more sense to make sure gnulib's stdint.h replacement is
>> enabled when SIZE_MAX is not provided by the system's stdint.h?  And
>> then deprecate size_max.h in favor of stdint.
>
> AFAICS, gettext and xsize are the only gnulib modules that use it,
> so deprecating size_max sounds like a good idea, assuming
> Bruno doesn't mind adjusting those two modules.

Hm, I think we have already discussed that at some point and Bruno
wanted to keep using it.  However, nothing in gnulib is using size_max.h
and deprecating that in favor of stdint.h seems non-controversial.

So how about this patch?

Of course, stdint.h has to define SIZE_MAX on these systems to make sure
it will still work.  But I suppose we'll notice if it doesn't already.

/Simon

>From 62f1470d951412a388560bca7e10b2c99b82224f Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Tue, 6 Oct 2009 13:55:18 +0200
Subject: [PATCH] size_max: Drop size_max.h.

---
 ChangeLog        |    6 ++++++
 NEWS             |    3 +++
 lib/size_max.h   |   31 -------------------------------
 modules/size_max |    4 ----
 4 files changed, 9 insertions(+), 35 deletions(-)
 delete mode 100644 lib/size_max.h

diff --git a/ChangeLog b/ChangeLog
index c942631..d3e4938 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-10-06  Simon Josefsson  <address@hidden>
+
+       * lib/size_max.h: Remove file.
+       * modules/size_max: Drop size_max.h.
+       * NEWS: Explain.
+
 2009-10-06  Jim Meyering  <address@hidden>
 
        linkat: avoid compilation failure
diff --git a/NEWS b/NEWS
index 62c631f..f32e031 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,9 @@ User visible incompatible changes
 
 Date        Modules         Changes
 
+2009-10-06  size_max        The header file "size_max.h" has been removed,
+                            use <stdint.h> from the stdint.h module instead.
+
 2009-09-16  canonicalize-lgpl
                             The include file is changed from "canonicalize.h"
                             to <stdlib.h>.
diff --git a/lib/size_max.h b/lib/size_max.h
deleted file mode 100644
index ed0bc13..0000000
--- a/lib/size_max.h
+++ /dev/null
@@ -1,31 +0,0 @@
-/* size_max.h -- declare SIZE_MAX through system headers
-   Copyright (C) 2005-2006 Free Software Foundation, Inc.
-   Written by Simon Josefsson.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2, or (at your option)
-   any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software Foundation,
-   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */
-
-#ifndef GNULIB_SIZE_MAX_H
-#define GNULIB_SIZE_MAX_H
-
-/* Get SIZE_MAX declaration on systems like Solaris 7/8/9.  */
-# include <limits.h>
-/* Get SIZE_MAX declaration on systems like glibc 2.  */
-# if HAVE_STDINT_H
-#  include <stdint.h>
-# endif
-/* On systems where these include files don't define it, SIZE_MAX is defined
-   in config.h.  */
-
-#endif /* GNULIB_SIZE_MAX_H */
diff --git a/modules/size_max b/modules/size_max
index 13554ae..bf35aeb 100644
--- a/modules/size_max
+++ b/modules/size_max
@@ -2,7 +2,6 @@ Description:
 Provide SIZE_MAX.
 
 Files:
-m4/size_max.m4
 lib/size_max.h
 
 Depends-on:
@@ -11,14 +10,11 @@ configure.ac:
 gl_SIZE_MAX
 
 Makefile.am:
-lib_SOURCES += size_max.h
 
 Include:
-"size_max.h"
 
 License:
 LGPLv2+
 
 Maintainer:
-Simon Josefsson
 Bruno Haible
-- 
1.6.3.3