[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: areadlinkat
From: |
Eric Blake |
Subject: |
Re: areadlinkat |
Date: |
Wed, 07 Oct 2009 19:36:20 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
[moved to bug-gnulib; I accidentally posted the patch series to bug-coreutils]
According to Eric Blake on 10/7/2009 11:00 AM:
> Eric Blake <ebb9 <at> byu.net> writes:
>
>> The patch copies from areadlink.c, as well as link_follow earlier in
>> linkat.c, to create two new fd-relative helpers. For now, I didn't see
>> any reason to expose them, but areadlinkat may someday be worth making
>> into a full-blown module.
>
> Further looking shows that:
>
> findutils' listfile.c currently uses a home-rolled get_link_name_at which
> blindly changes the working directory, and calls xalloc_die on allocation
> failure. Perfect candidate for xreadlinkat, to be more efficient on
> platforms
> with native readlinkat. And xreadlinkat implies areadlinkat.
>
> coreutils' copy.c currently uses areadlink_with_size for copying/moving
> symlinks across partitions, but since we want to rewrite this to use fts, we
> will need an *at variant.
>
> So, I've written three new modules: areadlinkat, areadlinkat-with-size, and
> xreadlinkat; mirroring the three existing modules areadlink, areadlink-with-
> size, xreadlink.
>
> Eric Blake (4):
> areadlink, areadlink-with-size: add tests
> areadlinkat: new module
> xreadlinkat: new module
> areadlinkat-with-size: new module
Based on Jim's preliminary review, I've now pushed this series.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkrNQhMACgkQ84KuGfSFAYBluwCgt7klY438DrT2En4hvM+fCXnX
s4sAnRBwhu1xnnFr92GcLk6At+Vvrk1A
=5pqZ
-----END PGP SIGNATURE-----
- Re: size_max, (continued)
- Re: size_max, Bruno Haible, 2009/10/06
- Re: size_max, Bruno Haible, 2009/10/06
- Re: size_max, Eric Blake, 2009/10/06
- Re: size_max, Bruno Haible, 2009/10/06
- Re: size_max, Simon Josefsson, 2009/10/07
- Re: new snapshot available: coreutils-7.6.63-addb6, Eric Blake, 2009/10/06
- Re: SIZE_MAX, Bruno Haible, 2009/10/06
- Re: SIZE_MAX, Simon Josefsson, 2009/10/07
- Re: new snapshot available: coreutils-7.6.63-addb6, Paolo Bonzini, 2009/10/06
- Re: new snapshot available: coreutils-7.6.63-addb6, Pádraig Brady, 2009/10/06
Message not available
Message not available