bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: use of AC_SUBST


From: Bruno Haible
Subject: Re: use of AC_SUBST
Date: Sun, 18 Oct 2009 19:18:23 +0200
User-agent: KMail/1.9.9

Jim Meyering wrote:
> your patch was already moving the AC_SUBST use,
> which was technically unnecessarily.

Huh? There is a 'case' statement in gl_GETHRXTIME. If the user had
set LIB_GETHRXTIME as an environment variable and the first alternative
of the 'case' statement was chosen, the value propagated into
config.status would have been the value of the environment variable,
not the empty string - leading to build problems. Therefore I moved
the LIB_GETHRXTIME= initialization. And then I moved the
AC_SUBST invocation because the code was using the traditional
coding style explained in the last mail.

> If you want to be pedantic, you would not have moved it at all,
> rather than impose *your* style.

That style was already present in the previous version of the file.
You cannot say that I imposed it when Paul Eggert coded it that way.

> "traditional" does not always equate to "best practice".

Not always. But in this case I find the traditional style more
maintainable.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]