Re: [PATCH] core-count: A new program to count the number of cpu cores

[Pádraig Brady]

Giuseppe Scrivano wrote:
> Hi Pádraig,
> 
> Pádraig Brady <address@hidden> writes:
> 
>> How about removing the --current option as it's now redundant.
>> A whole option to do nothing seems wrong. Also I think "available" is
>> more understandable than "current". Perhaps the various (future) sets
>> might be better as an option parameter. I.E how about:
>>
>>   nproc --count={all,available}
>>
>> with --count=available being the default operation.
> 
> Right, "available" looks better than "current", I'll change it.

cool

> I would avoid this interface, as it causes longer commands while using
> two separate options can be shortened by getopt.  I don't think that
> "--count" improves the readability (considering that nproc can't do
> anything else) so much to sacrifice that possibility.  What do you
> think?

Well --available and --all are mutually exclusive and related.
That fact is obvious if they're parameters to a single option.
But I do take your point that --count is a bit redundant,
and I don't see nproc getting many other options, so OK
leave them as separate options.

I'll hope to commit this soon.

cheers,
Pádraig.