bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] update M4 for INET_NTOP and INET_PTON checks.


From: Simon Josefsson
Subject: Re: [patch] update M4 for INET_NTOP and INET_PTON checks.
Date: Thu, 05 Nov 2009 13:57:24 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Bruno Haible <address@hidden> writes:

> Simon Josefsson wrote:
>> The recent inet_?to?.m4 change caused build failures in GnuTLS
>
> To avoid future regressions of this kind on these modules, I'm adding a
> unit test. Only for IPv4 so far. Feel free to extend it to cover IPv6.
>
>       Tests for module 'inet_pton'.
>       * modules/inet_pton-tests: New file.
>       * tests/test-inet_pton.c: New file.
>
>       Tests for module 'inet_ntop'.
>       * modules/inet_ntop-tests: New file.
>       * tests/test-inet_ntop.c: New file.

Great!

>> Does some autoconf version use the magic string "none needed" and other
>> versions "none required"?
>
> No, all autoconf version use the magic string "none required". I checked
> them all, since version 2.53. I don't know wherefrom you had the
> literal "none needed".

Copy'n'paste from other gnulib modules:

openmp.m4:       [ac_cv_prog_[]_AC_LANG_ABBREV[]_openmp='none needed'],
openmp.m4:      "none needed" | unsupported)
sockets.m4:        gl_cv_lib_socket="none needed"
sockets.m4:    if test "$gl_cv_lib_socket" != "none needed"; then

However perhaps these are not using AC_SEARCH_LIBS, so it is a different
magic string.

>> Perhaps the inet_?to?.m4 code needs to check for both magic strings?
>
> I think it's sufficient to let it check for the correct magic string.
> I'm applying this:

I prefer that too.

Thanks,
Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]