bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getaddrinfo needs $(INET_NTOP_LIB)


From: Eric Blake
Subject: Re: getaddrinfo needs $(INET_NTOP_LIB)
Date: Thu, 5 Nov 2009 16:33:33 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Simon Josefsson <simon <at> josefsson.org> writes:

> > Wouldn't it be nicer to rewrite the getaddrinfo.m4 to guarantee that
> > $(GETADDRINFO_LIB) contains the contents of $(INET_NTOP_LIB), so that
> > there is only one link line?
> 
> Hm, good point.  How about this?

Yes, I like it - it hides the implementation details of GETADDRINFO_LIB 
(coreutils directly uses getaddrinfo but not inet_ntop, so coreutils' 
Makefile.am should not have to mention $(INET_NTOP_LIB)).

> --- a/m4/getaddrinfo.m4
> +++ b/m4/getaddrinfo.m4
> @@ -96,6 +96,7 @@ AC_DEFUN([gl_PREREQ_GETADDRINFO], [

Serial number bump?

-- 
Eric Blake







reply via email to

[Prev in Thread] Current Thread [Next in Thread]