Re: memchr, unused getpagesize dependency?

[Simon Josefsson]

Jim Meyering <address@hidden> writes:

> Simon Josefsson wrote:
>> Jim, as far as I can tell, nothing in the 'memchr' module needs the
>> getpagesize module.  Old dependency?
>
> Hi Simon,
>
> New, actually.
> It's used by memchr.m4 and was added by this change:
>
> commit 7cf183c33ef0c792b5c93dbb4ac5b7858ee03986
> Author: Eric Blake <address@hidden>
> Date:   Mon Jun 8 06:29:17 2009 -0600
>
>     memchr: detect broken x86_64 and alpha implementations
>
>     * modules/memchr-tests (Depends-on): Move mmap detection...
>     * modules/memchr (Depends-on): ...here.
>     (configure.ac): Set indicator.
>     * lib/string.in.h (memchr): Declare replacement.
>     * modules/string (Makefile.am): Trigger replacement.
>     * m4/string_h.m4 (gl_HEADER_STRING_H_DEFAULTS): Likewise.
>     * m4/memchr.m4 (gl_FUNC_MEMCHR): Use mmap to detect platform
>     bugs.
>     * doc/posix-functions/memchr.texi (memchr): Document the bug.
>     * modules/getpagesize (License): Relax license.

Still, I don't see anything from the getpagesize module being used by
the memchr module including memchr.m4?  Yes, the C code test in
memchr.m4 does call getpagesize, but the gnulib replacement module for
getpagesize is not effective at that point (right?).  Nothing else in
memchr.m4 appear to use anything from getpagesize.m4 as far as I can
see.  And after the memchr.m4 test has been made, nothing else in memchr
is using getpagesize.

Eric?

/Simon