Re: Explicit interpreter paths considered harmful

[Simon Josefsson]

address@hidden (Ludovic Courtès) writes:

> Hello,
>
> Simon Josefsson <address@hidden> writes:
>
>> I'm considering simply doing the following, since the recommended way to
>> invoke the awk script is by 'awk -f SCRIPT'.  Thoughts?
>
> Then it’d be nice to clear the executable bit as well.

Sounds fine.  I'll push the patch below shortly.

/Simon

>From c62069100999651226c77d18b158bbf1ce2a4185 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Fri, 6 Nov 2009 14:26:16 +0100
Subject: [PATCH] build-aux/pmccabe2html: Disable execute bit. Improve example 
usage.

---
 ChangeLog              |    6 ++++++
 build-aux/pmccabe2html |    8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)
 mode change 100755 => 100644 build-aux/pmccabe2html

diff --git a/ChangeLog b/ChangeLog
index 73991dc..ce7f141 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2009-11-06  Simon Josefsson  <address@hidden>
 
+       * build-aux/pmccabe2html: Disable execute bit.  Suggested by
+       Reported by Ludovic Courtès.
+       * build-aux/pmccabe2html: Improve example usage.
+
+2009-11-06  Simon Josefsson  <address@hidden>
+
        * modules/select-tests (test_select_LDADD): Add $(INET_PTON_LIB)
        because test-select.c uses inet_pton.
 
diff --git a/build-aux/pmccabe2html b/build-aux/pmccabe2html
old mode 100755
new mode 100644
index bc0f6e8..ea3e262
--- a/build-aux/pmccabe2html
+++ b/build-aux/pmccabe2html
@@ -23,14 +23,14 @@ exec awk -f "$0" "$@"
 
 # Typical Invocation is from a Makefile.am:
 #
-# cyclo-libidn.html:
+# cyclo-$(PROJECT).html:
 #      $(PMCCABE) ${top_srcdir}/lib/*.[ch] \
 #              | sort -nr \
 #              | $(AWK) -f ${top_srcdir}/build-aux/pmccabe2html \
 #                      -v lang=html -v name="$(PACKAGE_NAME)" \
-#                      -v 
vcurl="http://git.savannah.gnu.org/gitweb/?p=libidn.git;a=blob;f=%FILENAME%;hb=HEAD";
 \
-#                      -v url="http://www.gnu.org/software/libidn/"; \
-#                       -v css=../../build-aux/pmccabe.css \
+#                      -v 
vcurl="http://git.savannah.gnu.org/gitweb/?p=$(PROJECT).git;a=blob;f=%FILENAME%;hb=HEAD"
 \
+#                      -v url="http://www.gnu.org/software/$(PROJECT)/" \
+#                       -v css=${top_srcdir}/build-aux/pmccabe.css \
 #                      > tmp
 #      mv tmp $@
 #
-- 
1.6.5.2