[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memchr, unused getpagesize dependency?
From: |
Eric Blake |
Subject: |
Re: memchr, unused getpagesize dependency? |
Date: |
Fri, 06 Nov 2009 06:28:04 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 11/6/2009 6:18 AM:
>> Still, I don't see anything from the getpagesize module being used by
>> the memchr module including memchr.m4? Yes, the C code test in
>> memchr.m4 does call getpagesize, but the gnulib replacement module for
>> getpagesize is not effective at that point (right?).
It looks like you're right. getpagesize is not standardized, but
according to doc/glibc-functions claims that every platform that has
mprotect also has a working getpagesize, so it's not like memchr.m4 is
going to encounter a compilation/link failure for use of an undefined
getpagesize.
> It looks like the dependency can be removed.
I concur; go ahead and commit your suggested change.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkr0JGQACgkQ84KuGfSFAYDPCwCfa4FzbkENPVMJR9NirmdXtMGi
hKwAn2G2r7JDcyO9QiwgfASodhE77H2I
=n2ev
-----END PGP SIGNATURE-----