[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memchr, unused getpagesize dependency?
From: |
Simon Josefsson |
Subject: |
Re: memchr, unused getpagesize dependency? |
Date: |
Fri, 06 Nov 2009 14:37:30 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> According to Jim Meyering on 11/6/2009 6:18 AM:
>>> Still, I don't see anything from the getpagesize module being used by
>>> the memchr module including memchr.m4? Yes, the C code test in
>>> memchr.m4 does call getpagesize, but the gnulib replacement module for
>>> getpagesize is not effective at that point (right?).
>
> It looks like you're right. getpagesize is not standardized, but
> according to doc/glibc-functions claims that every platform that has
> mprotect also has a working getpagesize, so it's not like memchr.m4 is
> going to encounter a compilation/link failure for use of an undefined
> getpagesize.
>
>> It looks like the dependency can be removed.
>
> I concur; go ahead and commit your suggested change.
Thanks, pushed.
/Simon