[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix $m4dirs count
From: |
Eric Blake |
Subject: |
Re: [PATCH] Fix $m4dirs count |
Date: |
Mon, 9 Nov 2009 18:55:55 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Robert Millan <rmh <at> aybabtu.com> writes:
> $m4dirs is incorrectly counting. In my particular case
> (correct value: 0, detected value: 1), this resulted in gnulib-tool
> silently exitting with no visible error (and no job done).
>
> - m4dirs_count=`echo "$m4dirs" | wc -l`
> + m4dirs_count=`echo -n "$m4dirs" | wc -l`
This is wrong, since 'echo -n' is not portable. It should use printf instead,
or find some other portable way to count $m4dirs.
--
Eric Blake