bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix build warning in fnmatch_loop.c


From: Eric Blake
Subject: Re: [PATCH] fix build warning in fnmatch_loop.c
Date: Mon, 9 Nov 2009 19:39:06 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Robert Millan <rmh <at> aybabtu.com> writes:

> Fixes a build warning in fnmatch_loop.c.
> 
> 
> -    : p - startp + 1);      \
> +    : (unsigned) (p - startp) + 1);      \ 

I'm not a fan of unnecessary casts.  Can't we instead write this as:

: p - startp + 1U;

to still show that we intend for unsigned math, but without a cast?

-- 
Eric Blake






reply via email to

[Prev in Thread] Current Thread [Next in Thread]