bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests: avoid a spurious timeout on a heavily-loaded system


From: Eric Blake
Subject: Re: tests: avoid a spurious timeout on a heavily-loaded system
Date: Fri, 13 Nov 2009 09:07:20 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 11/13/2009 8:41 AM:
>   - the second to avoid compilation failure on rawhide, presumably
>       due to its newer header files.

More likely, due to a cygwin bug for exposing SIZE_MAX without requiring
<stdint.h>.  Newer Linux is better about keeping headers namespace clean.
 getgroups.c was also impacted:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkr9hDcACgkQ84KuGfSFAYAYtwCgrvh9q2OrNaJJlzDbM2CY3MQX
pWwAniZb+m5xuhfXOhGKBhSYzqo8BgFi
=qtt8
-----END PGP SIGNATURE-----
>From f3a2c4aaa9ad3ed11c1437cdce8ae172fd273a1f Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Fri, 13 Nov 2009 09:06:14 -0700
Subject: [PATCH] getgroups: avoid compilation failure

* lib/getgroups.c (includes): Include <stdint.h> for SIZE_MAX.
* modules/getgroups (Depends-on): Add stdint.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog         |    6 ++++++
 lib/getgroups.c   |    1 +
 modules/getgroups |    1 +
 3 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ff6dd0e..44e2120 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-11-13  Eric Blake  <address@hidden>
+
+       getgroups: avoid compilation failure
+       * lib/getgroups.c (includes): Include <stdint.h> for SIZE_MAX.
+       * modules/getgroups (Depends-on): Add stdint.
+
 2009-11-13  Jim Meyering  <address@hidden>

        test-getgroups: avoid compilation failure
diff --git a/lib/getgroups.c b/lib/getgroups.c
index e4540fe..bb2b38d 100644
--- a/lib/getgroups.c
+++ b/lib/getgroups.c
@@ -24,6 +24,7 @@

 #include <errno.h>
 #include <stdlib.h>
+#include <stdint.h>

 #if !HAVE_GETGROUPS

diff --git a/modules/getgroups b/modules/getgroups
index 8ecbbdd..aabcefc 100644
--- a/modules/getgroups
+++ b/modules/getgroups
@@ -7,6 +7,7 @@ m4/getgroups.m4

 Depends-on:
 malloc-posix
+stdint
 unistd

 configure.ac:
-- 
1.6.5.rc1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]