bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pending patches?


From: Pádraig Brady
Subject: Re: pending patches?
Date: Fri, 13 Nov 2009 21:59:50 +0000
User-agent: Thunderbird 2.0.0.6 (X11/20071008)

Eric Blake wrote:
> According to Eric Blake on 11/13/2009 11:35 AM:
>>> Are you approaching a good cut-off point?
>> I've almost got chown working; expect patches later today.
> 
> Here's my candidate under testing.  It passed FreeBSD 7.2, but I still
> need to check it on Solaris 9.
> 

Wow the tests are impressive.
The only issue I noticed is:

+/* Work around trailing slash bugs in lchown.  */
+int
+rpl_lchown (const char *file, uid_t uid, gid_t gid)
+{
+  size_t len = strlen (file);
+  struct stat st;
+  if (file[len - 1] == '/')

if (len && ...)

cheers,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]