[PATCH] avoid new AC_REQUIRE expanded-before-required warnings

[Jim Meyering]

Hoping to use the latest gnulib in coreutils, I sync'd, committed (without
pushing yet, of course), and tried to bootstrap.  Running autoconf
produced warnings like this:

configure.ac:45: warning: AC_REQUIRE: `gl_FUNC_CHOWN' was expanded before it 
was required

Fixed that, then got others:

./bootstrap: aclocal --force -I m4 ...
configure.ac:45: warning: AC_REQUIRE: `gl_FUNC_EUIDACCESS' was expanded before 
it was required
m4/faccessat.m4:11: gl_FUNC_FACCESSAT is expanded from...
m4/gnulib-comp.m4:48: gl_INIT is expanded from...
configure.ac:45: the top level

Here's how I ended up fixing things in gnulib:

>From 1b712ba8bb1359974aa495a1a95b2185ed68e87e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 16 Nov 2009 10:22:53 +0100
Subject: [PATCH] avoid new AC_REQUIRE expanded-before-required warnings

* modules/chown (configure.ac): Require gl_FUNC_CHOWN, rather than
merely using it.
* modules/euidaccess (configure.ac): Likewise for gl_FUNC_EUIDACCESS.
* modules/faccessat (configure.ac): Likewise for gl_FUNC_FACCESSAT.
---
 ChangeLog          |    8 ++++++++
 modules/chown      |    2 +-
 modules/euidaccess |    2 +-
 modules/faccessat  |    2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index a005a68..5bcb9a0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-11-16  Jim Meyering  <address@hidden>
+
+       avoid new AC_REQUIRE expanded-before-required warnings
+       * modules/chown (configure.ac): Require gl_FUNC_CHOWN, rather than
+       merely using it.
+       * modules/euidaccess (configure.ac): Likewise for gl_FUNC_EUIDACCESS.
+       * modules/faccessat (configure.ac): Likewise for gl_FUNC_FACCESSAT.
+
 2009-11-15  Simon Josefsson  <address@hidden>

        * tests/test-xalloc-die.c: New file.
diff --git a/modules/chown b/modules/chown
index 88d0cd4..57331c3 100644
--- a/modules/chown
+++ b/modules/chown
@@ -13,7 +13,7 @@ stat
 sys_stat

 configure.ac:
-gl_FUNC_CHOWN
+AC_REQUIRE([gl_FUNC_CHOWN])
 gl_UNISTD_MODULE_INDICATOR([chown])

 Makefile.am:
diff --git a/modules/euidaccess b/modules/euidaccess
index bf329c6..c313da3 100644
--- a/modules/euidaccess
+++ b/modules/euidaccess
@@ -13,7 +13,7 @@ stat
 sys_stat

 configure.ac:
-gl_FUNC_EUIDACCESS
+AC_REQUIRE([gl_FUNC_EUIDACCESS])
 gl_UNISTD_MODULE_INDICATOR([euidaccess])

 Makefile.am:
diff --git a/modules/faccessat b/modules/faccessat
index 92d8185..57f9497 100644
--- a/modules/faccessat
+++ b/modules/faccessat
@@ -13,7 +13,7 @@ openat
 unistd

 configure.ac:
-gl_FUNC_FACCESSAT
+AC_REQUIRE([gl_FUNC_FACCESSAT])
 gl_MODULE_INDICATOR([faccessat])
 gl_UNISTD_MODULE_INDICATOR([faccessat])

--
1.6.5.2.386.g2a326