bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] pread: new module


From: Jim Meyering
Subject: Re: [PATCH 1/2] pread: new module
Date: Wed, 25 Nov 2009 17:46:32 +0100

Eric Blake wrote:

> Jim Meyering <jim <at> meyering.net> writes:
>
>> +  off_t old_offset = __libc_lseek (fd, 0, SEEK_CUR);
>
>> +Depends-on:
>> +unistd
>> +
>
> Needs to depend on lseek, particularly since pread is replaced on mingw, and
> mingw has an lseek bug with non-seekable files (like pipes).
>
> Perhaps test-pread.sh should also check that pread fails with ESPIPE on a non-
> seekable fd?  Also, the test should probably cover EINVAL for trying to read
> negative offsets.

Thanks.
Good suggestions.
Will do.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]