Re: Solaris 10 nanosleep link failure

[Jim Meyering]

Eric Blake wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>> FYI, building latest coreutils on Solaris 10,
>> I get this failure:
>>
>>     CCLD     sort
>>   Undefined                       first referenced
>>    symbol                             in file
>>   nanosleep                           ../lib/libcoreutils.a(xnanosleep.o)
>>   ld: fatal: Symbol referencing errors. No output written to sort
>>   collect2: ld returned 1 exit status
>>   make[3]: *** [sort] Error 1
>>
>> I'll look into it tomorrow if no one beats me to it
>
> This should do it.  Regression caused by commit f9d0bb8481b in coreutils.
> Sorry for not catching that when I fixed the sort link failure on cygwin.
>
>
> From: Eric Blake <address@hidden>
> Date: Tue, 1 Dec 2009 08:18:28 -0700
> Subject: [PATCH] sort: fix link failure on Solaris
>
> Commit f9d0bb8481 made sort depend on xnanosleep.
>
> * src/Makefile.am (sort_LDADD): Add LIB_NANOSLEEP.
> ---
>  src/Makefile.am |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index be1df2b..208cb6c 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -349,6 +349,7 @@ uptime_LDADD += $(POW_LIB)
>
>  # for xnanosleep
>  sleep_LDADD += $(LIB_NANOSLEEP)
> +sort_LDADD += $(LIB_NANOSLEEP)
>  tail_LDADD += $(LIB_NANOSLEEP)

Ahh... of course.  Thanks!
Please push that.

BTW, I just saw this go by while testing on freebsd8:

    ...
    Abort trap (core dumped)
    FAIL: test-getopt